← Back to index | Original Bugzilla link

Bug 22770 – C++ header generator generates trailing newlines

Status: RESOLVED
Resolution: FIXED
Severity: enhancement
Priority: P1
Component: dmd
Product: D
Version: D2
Platform: All
OS: All
Creation time: 2022-02-13T22:38:00Z
Last change time: 2022-03-03T16:17:59Z
Keywords: pull
Assigned to: No Owner
Creator: Luís Ferreira

Comments

Comment #0 by contact — 2022-02-13T22:38:00Z

The compiler should check for trailing newlines in the header buffer and avoid writing those to generate a clean header at the end.

Comment #1 by dlang-bot — 2022-02-13T22:40:56Z

@ljmf00 created dlang/dmd pull request #13649 "Fix issue 22770: C++ header generator generates trailing newlines" fixing this issue: - Fix issue 22770: C++ header generator generates trailing newlines This patch adds logic to check for trailing newlines in dtoh generator and remove them. Signed-off-by: Luís Ferreira <[email protected]> https://github.com/dlang/dmd/pull/13649

Comment #2 by dlang-bot — 2022-03-03T16:17:59Z

dlang/dmd pull request #13649 "Fix issue 22770: C++ header generator generates trailing newlines" was merged into master: - 5e32ea6aec91c6829027803a8c408f8cc0939af3 by Luís Ferreira: Fix issue 22770: C++ header generator generates trailing newlines This patch adds logic to check for trailing newlines in dtoh generator and remove them. Signed-off-by: Luís Ferreira <[email protected]> https://github.com/dlang/dmd/pull/13649