Bug 23266 – Dead else blocks are not considered unreachable

This code, built with -w, gives a "statement is not reachable" warning on the second return: void main() { if (true) return; return; } This code does not: void main() { if (true) return; else return; } This despite the else block being just as unreachable.

One could argue that this is correct because otherwise the common technique of stubbing out an if statement by adding `if (false &&` stops working. For the CompoundStatement error to trigger with that, you'd need to do `if (true &&`, which is much more rare.

I've tried a DMD branch that errors with -w if `if()` has a statically known true condition and an else block. The two main things I ran into in Phobos are: 1. if (false) { some code that should affect function attributes but never be run; } 2. if (...) that should be static if (...) For one the warning is useful, for the other it's harmful...

The unreachable code warning will be disabled in the next release of the compiler. https://github.com/dlang/dmd/pull/15568 I suggest we close this. WONTFIX? There's no MOOT status!

GOODEND