Bug 23561 – std.typecons.Unique!struct does not destroy struct instance

void main() { import std.typecons; int i; struct S { ~this() { i++; } } { Unique!S u = new S; } assert(i == 1); // fails } Unique.~this calls destroy on the S*, not the struct instance: if (_p !is null) { destroy(_p); _p = null; }

import std.stdio; static int i; struct S { ~this() { i++; writeln("DTOR: i == ", i ); } } void main() { { auto u = new S; u.destroy(); // (*u).destroy(); // works fine! } import core.memory; GC.collect(); writeln("EXIT: i == ", i ); // 0, but except 1 assert(i == 1); // fails } // Output: // EXIT: i == 0 // DTOR: i == 1 // // core.exception.AssertError@source\app.d(24): Assertion failure Confirm. Also failed. FAIL: Destructor S, possible not called. WANTED: Wanted to call S.~this(). PURPOSE: smart-pointer. std.typecons.Unique!S for auto close handle. DMD: DMD32 D Compiler v2.101.0-dirty, Windows 10, x64 DMD: LDC 1.30, Windows 10, x64

But works when S is class: class S { ~this() { i++; writeln("DTOR: i == ", i ); } }

@ntrel created dlang/phobos pull request #8651 "Fix Issue 23561 - std.typecons.Unique!struct does not destroy struct …" fixing this issue: - Fix Issue 23561 - std.typecons.Unique!struct does not destroy struct instance https://github.com/dlang/phobos/pull/8651

dlang/phobos pull request #8651 "Fix Issue 23561 - std.typecons.Unique!struct does not destroy struct …" was merged into master: - 8df49f52fd8a36a2247e15cc47e8b165e0dd485f by Nick Treleaven: Fix Issue 23561 - std.typecons.Unique!struct does not destroy struct instance https://github.com/dlang/phobos/pull/8651