Bug 23949 – core.stdc.assert_ for FreeBSD and DragonFlyBSD is incorrect
Status
RESOLVED
Resolution
FIXED
Severity
normal
Priority
P1
Component
druntime
Product
D
Version
D2
Platform
x86_64
OS
FreeBSD
Creation time
2023-05-31T12:52:26Z
Last change time
2023-06-02T13:34:09Z
Keywords
pull
Assigned to
No Owner
Creator
mail
Comments
Comment #0 by mail — 2023-05-31T12:52:26Z
The __assert function prototype in core.stdc.assert_ is incorrect for FreeBSD.
Currently on D is:
noreturn __assert(const(char)* exp, const(char)* file, uint line);
But according to the FreeBSD header it should be:
noreturn __assert(const(char)* fun, const(char)* file, uint line, const(char)* exp);
Comment #1 by dlang-bot — 2023-05-31T12:53:48Z
@ErnyTech created dlang/dmd pull request #15285 "Fix issue 23949 - core.stdc.assert_ for FreeBSD is incorrect" fixing this issue:
- Fix issue 23949 - core.stdc.assert_ for FreeBSD is incorrect
Also add missing noreturn from previous PR
https://github.com/dlang/dmd/pull/15285
Comment #2 by mail — 2023-05-31T13:06:44Z
Also DragonFlyBSD is incorrect
Comment #3 by dlang-bot — 2023-05-31T13:22:43Z
@ErnyTech created dlang/dmd pull request #15286 "[BACKPORT] Fix issue 23949 - core.stdc.assert_ for FreeBSD is incorrect" mentioning this issue:
- [BACKPORT] Fix issue 23949 - core.stdc.assert_ for FreeBSD is incorrect
I added an empty string as a default parameter so as not to break the users' code in stable.
Don't merge these changes into master.
https://github.com/dlang/dmd/pull/15286
Comment #4 by dlang-bot — 2023-05-31T23:30:34Z
dlang/dmd pull request #15285 "Fix issue 23949 - core.stdc.assert_ for FreeBSD is incorrect" was merged into stable:
- 8a8b9dc8a73859171afd4b23c0b187608d258378 by Ernesto Castellotti:
Fix issue 23949 - core.stdc.assert_ for FreeBSD and DragonFlyBSD is incorrect
https://github.com/dlang/dmd/pull/15285
Comment #5 by dlang-bot — 2023-06-02T13:34:09Z
dlang/dmd pull request #15290 "merge stable" was merged into master:
- 0df0e6e626f1ab677e1a26cba3d00e906239a191 by Ernesto Castellotti:
Fix issue 23949 - core.stdc.assert_ for FreeBSD and DragonFlyBSD is incorrect
https://github.com/dlang/dmd/pull/15290