Bug 24337 – Segfault when printing an int[] cast from a string literal

This code segfaults dmd: ```D immutable ushort[] z = cast(immutable ushort[]) "ab"w; pragma(msg, z); ``` The problem is in expressionsem.d: ``` StringExp toUTF8(StringExp se, Scope* sc) { if (se.sz != 1) { // Convert to UTF-8 string se.committed = false; Expression e = castTo(se, sc, Type.tchar.arrayOf()); e = e.optimize(WANTvalue); auto result = e.isStringExp(); assert(result.sz == 1); return result; } return se; } ``` This function assumes casting a StringExp to char[] will always succeed, which is false in the above case.

@dkorpel created dlang/dmd pull request #16729 "Fix bugzilla 24337 - Segfault when printing an int[] cast from a stri…" fixing this issue: - Fix bugzilla 24337 - Segfault when printing an int[] cast from a string literal https://github.com/dlang/dmd/pull/16729

dlang/dmd pull request #16729 "Fix bugzilla 24337 - Segfault when printing an int[] cast from a stri…" was merged into stable: - bb41c7e0e2264d2bcdcc63d6cfc2f089e5f3f1b8 by Dennis Korpel: Fix bugzilla 24337 - Segfault when printing an int[] cast from a string https://github.com/dlang/dmd/pull/16729

dlang/dmd pull request #16967 "Rebase stable6" was merged into master: - 7e42effe7a5657d4443a7ea00e3509b889fd52b6 by Dennis: Fix bugzilla 24337 - Segfault when printing an int[] cast from a string (#16729) https://github.com/dlang/dmd/pull/16967

dlang/dmd pull request #17069 "Merge stable" was merged into master: - cf618a659c92a0a6fcbc9079af29c72a8af27b76 by Dennis: Fix bugzilla 24337 - Segfault when printing an int[] cast from a string (#16729) https://github.com/dlang/dmd/pull/17069