Bug 24509 – importC cannot handle _stdcall Function Calling Convention with single heading underscore

In Windows programming, the stdcall calling convention is usually specified using the __stdcall keyword or macro. The import c documentation also lists __stdcall calling convention with double underscores. However, there are some occurrences in c library headers using single underscores. For instance, Microsoft's onnx runtime [1]. This kind of usage is not handled with importc. Importc yields a syntax error for these situations, such as: onnxruntime_c_api.h(288,25): Error: expected identifier for declarator onnxruntime_c_api.h(288,25): Error: `;` or `,` expected 1: https://github.com/microsoft/onnxruntime/blob/08d208b969fec6e7f6505f4f468eea0d6a9031c2/include/onnxruntime/core/session/onnxruntime_c_api.h#L86

Is it enough to create an alias for _stdcall token? https://github.com/dlang/dmd/blob/9a86c4e06c5a22fb3be9f0daaec12b4120ef963f/compiler/src/dmd/tokens.d#L585 https://github.com/dlang/dmd/blob/9a86c4e06c5a22fb3be9f0daaec12b4120ef963f/compiler/src/dmd/cparse.d#L2404

My fix: https://github.com/aferust/dmd/commit/23e78aedb75931a27089ea1912d5fd56dd2d0c50 This is important because the MSVC compiler accepts both _stdcall and __stdcall, one or two underscores.

Final fix after the reviews by the maintainers: https://github.com/dlang/dmd/pull/16392

@aferust updated dlang/dmd pull request #16392 "Fix bugzilla 24509: importC cannot handle _stdcall Function Calling …" fixing this issue: - Fix bugzilla 24509: importC cannot handle _stdcall Function Calling Convention with single heading underscore https://github.com/dlang/dmd/pull/16392

dlang/dmd pull request #16392 "Fix bugzilla 24509: importC cannot handle _stdcall Function Calling …" was merged into stable: - d07aa342e513a0a34a6ee6ab0e29ea6c14a9bb3c by aferust: Fix bugzilla 24509: importC cannot handle _stdcall Function Calling Convention with single heading underscore https://github.com/dlang/dmd/pull/16392

dlang/dmd pull request #16406 "Merge stable" was merged into master: - d61f72cbdc701aad056bd71f0dcef7795becf210 by Ferhat Kurtulmuş: Fix bugzilla 24509: importC cannot handle _stdcall Function Calling … (#16392) * Fix bugzilla 24509: importC cannot handle _stdcall Function Calling Convention with single heading underscore https://github.com/dlang/dmd/pull/16406