Bug 24546 – importC musl setjmp.h failure

Status
RESOLVED
Resolution
FIXED
Severity
major
Priority
P1
Component
druntime
Product
D
Version
D2
Platform
All
OS
Linux
Creation time
2024-05-08T18:41:41Z
Last change time
2024-05-27T12:02:10Z
Keywords
ImportC, industry, pull
Assigned to
No Owner
Creator
johanengelen

Comments

Comment #0 by johanengelen — 2024-05-08T18:41:41Z
importC fails on musl libc setjmp.h, this line: https://github.com/cloudius-systems/musl/blob/00733dd1cf791d13ff6155509cf139a5f7b2eecb/include/setjmp.h#L15 It uses identifier `__ss` which is #defined by D's importc.h: https://github.com/dlang/dmd/blame/046679129774bf886e0650fa593c24fb2c7de499/druntime/src/importc.h#L73 Is it really needed to define `__ss` ?
Comment #1 by johanengelen — 2024-05-08T18:46:37Z
Comment #2 by kinke — 2024-05-09T12:09:10Z
I hardly find anything wrt. `__ss` via Google. MSVC doesn't seem to treat it in a special way, it's a valid identifier. Could this be a DMC specificum? https://digitalmars.com/ctg/pointers16.html
Comment #3 by dlang-bot — 2024-05-17T13:44:18Z
@JohanEngelen updated dlang/dmd pull request #16507 "Fix https://issues.dlang.org/show_bug.cgi?id=24546 for musl libc" fixing this issue: - Fix bugzilla 24546 for musl libc https://github.com/dlang/dmd/pull/16507
Comment #4 by dlang-bot — 2024-05-19T10:09:15Z
dlang/dmd pull request #16507 "Fix https://issues.dlang.org/show_bug.cgi?id=24546 for musl libc" was merged into stable: - af9f2e3234dc29f91f4029517260005a1cd87bb3 by Johan Engelen: Fix bugzilla 24546 for musl libc https://github.com/dlang/dmd/pull/16507
Comment #5 by dlang-bot — 2024-05-27T12:02:10Z
dlang/dmd pull request #16534 "merge stable" was merged into master: - cc66e60109fb99b0983b908ebd70f1a7f9499d76 by Johan Engelen: Fix bugzilla 24546 for musl libc (#16507) https://github.com/dlang/dmd/pull/16534