← Back to index | Original Bugzilla link

Bug 24861 – Vestige of 16 bit code being accidentally generated

Status: RESOLVED
Resolution: FIXED
Severity: minor
Priority: P1
Component: dmd
Product: D
Version: D2
Platform: x86
OS: All
Creation time: 2024-11-15T00:10:38Z
Last change time: 2024-11-15T02:13:25Z
Keywords: backend, pull
Assigned to: No Owner
Creator: Walter Bright

Comments

Comment #0 by bugzilla — 2024-11-15T00:10:38Z

Line 4667 of cod2.d is: if (pretregs & (mES | mCX) || e.Ety & mTYfar) but that branch should only be taken for 16 bit code. The code generated is benign, but it shouldn't be generated. The fix is: if (I16 && pretregs & (mES | mCX) || e.Ety & mTYfar)

Comment #1 by dlang-bot — 2024-11-15T00:13:05Z

@WalterBright created dlang/dmd pull request #17065 "fix bugzilla Issue 24861 - Vestige of 16 bit code being accidentally …" fixing this issue: - fix bugzilla Issue 24861 - Vestige of 16 bit code being accidentally generated https://github.com/dlang/dmd/pull/17065

Comment #2 by dlang-bot — 2024-11-15T02:13:25Z

dlang/dmd pull request #17065 "fix bugzilla Issue 24861 - Vestige of 16 bit code being accidentally …" was merged into master: - d8d94b1b04ee68823d03663e6f21e5c8a77553e5 by Walter Bright: fix bugzilla Issue 24861 - Vestige of 16 bit code being accidentally generated https://github.com/dlang/dmd/pull/17065