Bug 261 – _blocking flag not set in Socket.blocking on non-Windows systems

In the property setter Socket.blocking, the _blocking flag is being properly set on Windows, but not on other systems. The following is a fix: void blocking(bool byes) // setter { version(Win32) { uint num = !byes; if(_SOCKET_ERROR == ioctlsocket(sock, FIONBIO, &num)) goto err; // _blocking = byes; <-- Shouldn't be set in the version block } else version(BsdSockets) { int x = fcntl(sock, F_GETFL, 0); if(-1 == x) goto err; if(byes) x &= ~O_NONBLOCK; else x |= O_NONBLOCK; if(-1 == fcntl(sock, F_SETFL, x)) goto err; } // FIX _blocking = byes; return; // Success. err: throw new SocketException("Unable to set socket blocking", _lasterr()); }

There is no need to save _blocking on non-Windows since they provide a way to get this state in their sockets API.