Bug 313 – [module] Fully qualified names bypass private imports

In file a.d: -- // explicit private no longer needed but added for clarity private import std.stdio; -- In file b.d: -- import a; void main() { // compiler correctly reports "undefined identifier writefln" writefln("foo"); // works fine! std.stdio.writefln("foo"); }

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 [email protected] schrieb am 2006-08-27: > http://d.puremagic.com/issues/show_bug.cgi?id=313 > In file a.d: > -- > // explicit private no longer needed but added for clarity > private import std.stdio; > -- > In file b.d: > -- > import a; > > void main() { > // compiler correctly reports "undefined identifier writefln" > writefln("foo"); > // works fine! > std.stdio.writefln("foo"); > } Added to DStress as ( http://dstress.kuehne.cn/addon/import_16_A.d ) ( http://dstress.kuehne.cn/addon/import_16_B.d ) http://dstress.kuehne.cn/nocompile/i/import_16_C.d http://dstress.kuehne.cn/nocompile/i/import_16_D.d http://dstress.kuehne.cn/nocompile/i/import_16_E.d http://dstress.kuehne.cn/nocompile/i/import_16_F.d http://dstress.kuehne.cn/nocompile/i/import_16_G.d http://dstress.kuehne.cn/nocompile/i/import_16_H.d Thomas -----BEGIN PGP SIGNATURE----- iD8DBQFFCI/kLK5blCcjpWoRAr2vAJ9kMpOBRbvfc+shCaY5sUmJ2A0mHgCgiqwL gXiXz3j5CfhZNxSD/od/FP4= =t6HB -----END PGP SIGNATURE-----

d 1.0 does correctly report the error message

David, did you test on Windows? import_16_C, D, F - H still fail on Linux.

*** Bug 880 has been marked as a duplicate of this bug. ***

Although this particular bug is fixed as of dmd 1.037 and 2.021, there are other cases that fail.

---- a.d ---- import b; void main() { std.stdio.writefln("Hello"); } ---- b.d ---- public import std.ascii; private import std.stdio; ------------- dmd -c a

*** Issue 1504 has been marked as a duplicate of this issue. ***

*** Issue 5411 has been marked as a duplicate of this issue. ***

*** Issue 6307 has been marked as a duplicate of this issue. ***

*** Issue 7496 has been marked as a duplicate of this issue. ***

The issue is that all imports are inserted into a global package tree. Whenever you have access to a root package, e.g. by importing std.stdio, one can access all 'std' children that were imported with a qualified name. A possible fix would be to create one package tree (or a view of it) for each module.

Commit pushed to master at https://github.com/D-Programming-Language/druntime https://github.com/D-Programming-Language/druntime/commit/efe7e94030d75780b16a4eaf45c8dfb789c899aa Merge pull request #532 from 9rnsr/fix_imports Issue 313 & 314 - Add package access to rt.lifetime.BlkInfo

Commits pushed to master at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/03a32d6fa4635543eed17b874fbf7a0330572ac3 Fix issue 313 & 314 https://github.com/D-Programming-Language/phobos/commit/b7216eae2e9ec73e186a713c59839fd91c9347b7 Merge pull request #1368 from 9rnsr/fix_imports Fix issue 313 & 314 - Add necessary imports and fix FQN accesses

Commits pushed to master at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/2f21ff0c74cda26b4a5c039b358b8451c450fbde More fix for issue 313 & 314 https://github.com/D-Programming-Language/phobos/commit/92e279a9733b0b4af53f141649368976652d9ce2 Merge pull request #1372 from 9rnsr/fix_imports More fix for issue 313 & 314

Commits pushed to master at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/3e791f6bc6046e4ca7e9e650a573ffaa9f0c3403 Add import declarations for issue 313 & 314 https://github.com/D-Programming-Language/phobos/commit/e2e986c7b6533c9042dbbdc23960e287e206ea12 Merge pull request #1811 from 9rnsr/fix_imports Add import declarations for issue 313 & 314

Commits pushed to master at https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/9c204d91275664a4c91c42b61bdad0c05849a6c7 fix Issue 313 - [module] Fully qualified names bypass private imports https://github.com/D-Programming-Language/dmd/commit/6cf399220142a05aba69be2f1ed489496a625aff Merge pull request #2256 from 9rnsr/fix_imports Fix issue 313 & 314 implement more strict import mechanism

(In reply to Kenji Hara from comment #14) > https://github.com/D-Programming-Language/dmd/pull/2256 Unfortunately it was finally reverted. Instead of that, more conservative fix for the issues 313 & 311 is now opened. https://github.com/D-Programming-Language/dmd/pull/3407

Commits pushed to master at https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/ea25aad26d11951ccbcd2a57f8c3add968f32434 fix Issue 313 - Fully qualified names bypass private imports - b/c we're using a global package tree, imported modules were accessible in other scopes using fully qualified names - maintain a whitelist of imported modules in the current scope https://github.com/D-Programming-Language/dmd/commit/eb8c2c7a48404495d3a62ee5bd58e28a654e99d5 Merge pull request #5426 from MartinNowak/fix313 fix Issue 313 - Fully qualified names bypass private imports

*** Issue 13709 has been marked as a duplicate of this issue. ***

Commits pushed to master at https://github.com/dlang/dmd https://github.com/dlang/dmd/commit/aca10e8a720d8a00a09184e5fc065665ca3a2c13 Turn deprecation into error for issue 313 https://github.com/dlang/dmd/commit/01a6a5e26f7d2ed6fdab9286566ece803862c48a Merge pull request #8443 from RazvanN7/checkAccess_err Turn deprecation into error for issue 313 merged-on-behalf-of: Sebastian Wilzbach <[email protected]>

*** Issue 13462 has been marked as a duplicate of this issue. ***