Bug 3153 – win32.mak tries to copy phobos.lib, gcstub.obj to nonexistent folder lib

Status
RESOLVED
Resolution
FIXED
Severity
normal
Priority
P2
Component
phobos
Product
D
Version
D2
Platform
Other
OS
Windows
Creation time
2009-07-07T19:20:00Z
Last change time
2015-06-09T01:21:08Z
Keywords
patch
Assigned to
nobody
Creator
lio+bugzilla

Attachments

IDFilenameSummaryContent-TypeSize
416win32_install_lib.patchfixes the destination path to the new location: windows\libtext/plain527

Comments

Comment #0 by lio+bugzilla — 2009-07-07T19:20:46Z
Created attachment 416 fixes the destination path to the new location: windows\lib Since 2.025, the dmd zip contained an extensionless file "lib". This is because the directory structure was changed but some commands in win32.mak were not fixed: the 'install' target still copies files to the "lib" folder, but because the folder doesn't it exist, the copy commands assumes the target "lib" is a file. The attached patch fixes the destination path to the new location: windows\lib (Note: even after fixing the destination paths, "make -fwin32.mak install" still fails on my computer because it cannot find ..\druntime\lib\gcstub.obj)
Comment #1 by dfj1esp02 — 2009-07-08T01:51:30Z
To make sure that destination is a folder it must have trailing slash: --- $(CP) phobos.lib $(DIR)\windows\lib\ ---
Comment #2 by lio+bugzilla — 2009-07-08T02:02:19Z
(In reply to comment #1) > To make sure that destination is a folder it must have trailing slash: > --- > $(CP) phobos.lib $(DIR)\windows\lib\ > --- I tried it, it doesn't work. I think it doesn't work because in the makefile a line ending in a backslash is extended to include the next line, similar to C/C++. This is unfortunate for a makefile where there are plenty of paths :)
Comment #3 by dfj1esp02 — 2009-07-08T02:29:37Z
--- $(CP) phobos.lib $(DIR)\windows\lib\* --- :)
Comment #4 by bugzilla — 2009-09-03T13:40:34Z
Fixed dmd 2.032