Bug 3179 – [PATCH] Improvement of Inline Assembly D 2.0 specification

Status
NEW
Severity
enhancement
Priority
P4
Component
dlang.org
Product
D
Version
D2
Platform
All
OS
All
Creation time
2009-07-15T08:44:09Z
Last change time
2024-12-15T15:21:34Z
Keywords
iasm, patch, spec
Assigned to
No Owner
Creator
Julian Salazar
Moved to GitHub: dlang.org#4009 →

Attachments

IDFilenameSummaryContent-TypeSize
424iasm.diffDiff to existing iasm.ddtext/plain8782
425iasm-new.ddComplete upload of the edited iasm.dd fileapplication/octet-stream25564
426foo.gifwhat I'm seeing for the patch.image/gif42812

Comments

Comment #0 by julian — 2009-07-15T08:44:09Z
Created attachment 424 Diff to existing iasm.dd Here is a patch for the trunk/docsrc/iasm.dd file. The patch improves the specification by defining an x86-64 assembler syntax (registers, operands, etc), as well as clarifying certain keywords (like offsetof) and including opcodes for SSE4.1, SSE4.2, VMS and SMX in a table format.
Comment #1 by bugzilla — 2009-07-18T12:08:47Z
The patch is formatted by bugzilla as garbage. Can you please resubmit as a diff with the existing iasm.dd?
Comment #2 by julian — 2009-07-18T12:22:23Z
Created attachment 425 Complete upload of the edited iasm.dd file It should work (works on my end); I really don't see an issue, it's uploaded with a text/plain mime-type with the patch option selected. The diff link provided beside the attachment even outputs what the diff would do to the file. If it doesn't work on your end, I took the liberty of uploading the edited iasm.dd file itself to see if that works for you.
Comment #3 by braddr — 2009-07-18T12:29:43Z
Walter, could you define 'garbage'? The patch looks fine to me, though I didn't attempt to apply it.
Comment #4 by bugzilla — 2009-07-18T12:48:47Z
It has lost all of its whitespace formatting, is showing garbage hyperlinks, and is trying to show jpg's. It should be just a text file.
Comment #5 by bugzilla — 2009-07-18T12:54:15Z
Created attachment 426 what I'm seeing for the patch.
Comment #6 by julian — 2009-07-18T13:10:57Z
Methinks someone's browser is screwing up the mime-types... It looks to still be the same file but Walter's browser seems to be interpreting it as text/html? I think doing a save as to your computer as a *.patch file should do the trick.
Comment #7 by bugs-d — 2009-07-19T03:42:03Z
To view a graphical version of the diff: http://d.puremagic.com/issues/attachment.cgi?id=424&action=diff To view a text version, right click and save as this link: (do not left click in IE) http://d.puremagic.com/issues/attachment.cgi?id=424 Otherwise, use a better browser such as Firefox, Chrome, Opera, or Safari. (In reply to comment #6) > Methinks someone's browser is screwing up the mime-types... > > It looks to still be the same file but Walter's browser seems to be > interpreting it as text/html? I think doing a save as to your computer as a > *.patch file should do the trick. He's using IE, it does that. -[Unknown]
Comment #8 by bugzilla — 2012-01-23T01:19:15Z
A pull request for this would be nice.
Comment #9 by andrej.mitrovich — 2014-04-23T13:39:39Z
Any update on this? A pull would be very welcome now.
Comment #10 by blah38621 — 2014-04-23T14:54:27Z
I would agree that a pull would be welcome, however there is a snippet of code that this adds to the documentation with a very ill-advised version statement. It uses the identifier X86 rather than the identifier D_InlineAsm_X86.
Comment #11 by robert.schadek — 2024-12-15T15:21:34Z
THIS ISSUE HAS BEEN MOVED TO GITHUB https://github.com/dlang/dlang.org/issues/4009 DO NOT COMMENT HERE ANYMORE, NOBODY WILL SEE IT, THIS ISSUE HAS BEEN MOVED TO GITHUB