Bug 3443 – Thread.thread_needLock() should be nothrow
Status
RESOLVED
Resolution
FIXED
Severity
normal
Priority
P2
Component
druntime
Product
D
Version
D2
Platform
Other
OS
Windows
Creation time
2009-10-26T06:21:00Z
Last change time
2015-06-09T01:26:56Z
Assigned to
sean
Creator
dsimcha
Comments
Comment #0 by dsimcha — 2009-10-26T06:21:38Z
All it does is return a boolean member variable, so it clearly is really const pure nothrow. Fixing this would allow me to remove a serious kludge from some of my code.
Comment #1 by sean — 2009-10-30T21:53:04Z
This isn't even a member of Thread, it's a global extern (C) routine. I can mark it nothrow, but const doesn't make sense and pure doesn't apply, since its result depends on the value of a global.
Comment #2 by dsimcha — 2009-10-31T13:31:10Z
Good enough.
Comment #3 by sean — 2009-12-04T06:58:14Z
Added nothrow in r209.
Comment #4 by braddr — 2009-12-05T22:18:44Z
food for thought: the change doesn't match the bug description, and neither does the change log entry. I'd suggest changing both to better reflect what was done.