Bug 3446 – Rename float.min to float.min_normal

Status
RESOLVED
Resolution
FIXED
Severity
enhancement
Priority
P2
Component
dmd
Product
D
Version
D2
Platform
Other
OS
Windows
Creation time
2009-10-28T03:18:00Z
Last change time
2015-06-09T01:26:55Z
Keywords
patch
Assigned to
nobody
Creator
clugdbug

Attachments

IDFilenameSummaryContent-TypeSize
483patch3446.patchPatch against DMD2 svn221text/plain787

Comments

Comment #0 by clugdbug — 2009-10-28T03:18:15Z
Discussion: http://www.digitalmars.com/webnews/newsgroups.php?art_group=digitalmars.D&article_id=99283 Patch: About as simple as you can possibly imagine. idgen.c, line 116 { "infinity" }, { "dig" }, { "epsilon" }, + { "min_normal" }, { "mant_dig" }, { "max_10_exp" }, mtype.c, line 1989: else if (ident == Id::min) { switch (ty) { case Tint8: ivalue = -128; goto Livalue; case Tuns8: ivalue = 0; goto Livalue; case Tint16: ivalue = -32768; goto Livalue; case Tuns16: ivalue = 0; goto Livalue; case Tint32: ivalue = -2147483647L - 1; goto Livalue; case Tuns32: ivalue = 0; goto Livalue; case Tint64: ivalue = (-9223372036854775807LL-1LL); goto Livalue; case Tuns64: ivalue = 0; goto Livalue; case Tbool: ivalue = 0; goto Livalue; case Tchar: ivalue = 0; goto Livalue; case Twchar: ivalue = 0; goto Livalue; case Tdchar: ivalue = 0; goto Livalue; + } + } + else if (ident == Id::min_normal) + { + switch (ty) + { case Tcomplex32:
Comment #1 by leandro.lucarella — 2009-10-28T09:04:33Z
It would be too much trouble to publish the patches using diff -u and attaching them as a file? This way I can test them more easily. Thank you.
Comment #2 by clugdbug — 2009-10-28T09:10:46Z
Created attachment 483 Patch against DMD2 svn221 For Leandro. Walter normally puts the patches in manually, line-by-line, for tiny patches like this, so I've given up attaching patch files.
Comment #3 by leandro.lucarella — 2009-10-28T11:10:09Z
Thanks! I guess Walter will be able to do the modifications manually seeing the diff-generated patch anyway, and people wanting to test the patches before they actually committed can do it easily too =)
Comment #4 by bugzilla — 2009-11-04T11:55:11Z
Comment #5 by bugzilla — 2009-11-04T12:04:10Z
I'll put it in, but will leave .min working for now for backwards compatibility.
Comment #6 by clugdbug — 2009-11-04T12:06:35Z
(In reply to comment #5) > I'll put it in, but will leave .min working for now for backwards > compatibility. Awesome!
Comment #7 by leandro.lucarella — 2009-11-05T06:24:20Z
The documentation was updated in http://www.dsource.org/projects/phobos/changeset/1321. But there is no mention to .min being deprecated (because it is, right?). I think the documentation should reflect that. Thanks. Other related commits: http://www.dsource.org/projects/phobos/changeset/1322 http://www.dsource.org/projects/dmd/changeset/238
Comment #8 by bugzilla — 2009-11-06T11:35:20Z
Fixed dmd 2.036