Bug 3704 – split(char[],char[]) is broken for delimiters greater than a single character

There are no fewer than 4 critical errors in the latest implementation of split in phobos for the code path that deals with delimiters of length > 1. test code: import std.stdio; import std.string; void main() { foreach(item;"@match".split(" and ")) writefln("my data: %s",item); } Half of the problem is caused by using size_t (which is unsigned afaict) to capture the return value of find, which can be negative. This issue causes the following comparison to fail: if (j == -1) The other half is caused by not accounting for the fact that i can be greater than s.length, as well as equal. This causes the following comparison to fail to perform as expected: if (i == s.length)

Has this been fixed? I have no problem of using delimiters with sizes greater than 1: This works: import std.stdio; import std.string; void main() { foreach (item; "test test".split(" ")) { writefln("my data: %s", item); } }

If this bug report doesn't become more clear, then I suggest to eventually close it.

Closing this. 4 years old and works fine for me.