← Back to index | Original Bugzilla link

Bug 3752 – File.byLine fetches lines in a confusing manner

Status: RESOLVED
Resolution: FIXED
Severity: normal
Priority: P2
Component: phobos
Product: D
Version: D2
Platform: Other
OS: Linux
Creation time: 2010-01-29T08:25:00Z
Last change time: 2014-02-14T20:35:20Z
Assigned to: andrei
Creator: andrei

Attachments

ID	Filename	Summary	Content-Type	Size
559	stdio.patch	Rearranged using filled flag	text/plain	1759

Comments

Comment #0 by andrei — 2010-01-29T08:25:13Z

Refer to the newsgroup discussion "Re: Accessors, byLine, input ranges". The constructor of ByLine eagerly fetches a line (it shouldn't). The actual data transfer should ideally occur only in front().

Comment #1 by pelle.mansson — 2010-01-29T10:59:45Z

Created attachment 559 Rearranged using filled flag Now featuring an idle constructor. I hope I got the patch generation right. :)

Comment #2 by pelle.mansson — 2010-01-30T11:06:24Z

Actually, that's no good. Multiple calls to popFront will not advance the range. Ignore my patch, sorry about the noise.

Comment #3 by andrei — 2011-06-05T19:17:50Z

Fixed: https://github.com/D-Programming-Language/phobos/commit/7f154259fa8ffa7ab722d641e15bb68aeb6afac6