Bug 385 – unprotected command line parsing

DMD-0.167's argument parsing is unprotected against malicious command line arguments. Sample exploits: # # #include <unistd.h> # #include <stdlib.h> # # // sample 1 # execve("dmd", NULL, NULL); # # // sample 2 # char** arg = malloc(sizeof(char*)); # arg[0] = NULL; # execve("dmd", arg, NULL); # mars.c's current code: # # int status = EXIT_SUCCESS; # int argcstart = argc; # # // Initialization # Type::init(); # Id::initialize(); # Suggested fix: # # int status = EXIT_SUCCESS; # int argcstart = argc; # # // protect against malicious arguments # if (argc < 1 || !argv) # { usage(); # exit(EXIT_FAILURE); # } # for (i = 0; i < argc; i++) # { # if (!argv[i]) # { usage(); # exit(EXIT_FAILURE); # } # } # # // Initialization # Type::init(); # Id::initialize(); #

Fixed DMD 0.168