Bug 391 – .sort and .reverse break utf8 encoding

import std.utf; import std.stdio; void main() { char[] a; a = "\u3026\u2021\u3061\n"; writefln("plain"); validate(a); writefln("sorted"); validate(a.sort); // fails writefln("reversed"); validate(a.reverse); // fails }

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 [email protected] schrieb am 2006-10-02: > http://d.puremagic.com/issues/show_bug.cgi?id=391 > import std.utf; > import std.stdio; > void main() > { > char[] a; > a = "\u3026\u2021\u3061\n"; > writefln("plain"); validate(a); > writefln("sorted"); validate(a.sort); // fails > writefln("reversed"); validate(a.reverse); // fails > } Added to DStress as http://dstress.kuehne.cn/run/r/reverse_08_A.d http://dstress.kuehne.cn/run/r/reverse_08_B.d http://dstress.kuehne.cn/run/r/reverse_08_C.d http://dstress.kuehne.cn/run/s/sort_16_A.d http://dstress.kuehne.cn/run/s/sort_16_B.d http://dstress.kuehne.cn/run/s/sort_16_C.d Thomas -----BEGIN PGP SIGNATURE----- iD8DBQFFI033LK5blCcjpWoRAgxQAJ4soetJ+LZHkmwiFl5YqkGdrjmOjACeI2GG wkC8F4+qfNmVEbLeUT0t06g= =HqWF -----END PGP SIGNATURE-----

Fixed DMD 0.169

Process terminating with default action of signal 11 (SIGSEGV) Bad permissions for mapped region at address 0x805A0EC at 0x80544A3: _D3std8typeinfo8ti_dchar10TypeInfo_w4swapMFPvPvZv (in run/s/sort_16_A.d.exe) by 0x8050ACD: _adSort (in run/s/sort_16_A.d.exe) by 0x804A0F4: _Dmain (in run/s/sort_16_A.d:17) by 0x804BBE6: main (in run/s/sort_16_A.d.exe)

Fixed indeed in DMD 0.169 The test cases failed due to missing dups and thus trying to sort an constant string in place.

This case (cut down from reverse_08_C) is still failing. int main(){ wchar[] a = "a\U00000081b\U00002000c\U00010000"; wchar[] b = a.dup; b.reverse; // OK b.reverse; // fails return 0; }

Don's latest fails both on 1.065 and 2.050. Marking as a D1 & D2 issue.

Commit pushed to phobos-1.x at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/8b4f262f9ed898a82e55e269ee68a865d97cc122 fix Issue 391 - .sort and .reverse break utf8 encoding

Commit pushed to master at https://github.com/D-Programming-Language/druntime https://github.com/D-Programming-Language/druntime/commit/b30134123b200f0daa616015ac8d6bdcfb350c50 fix Issue 391 - .sort and .reverse break utf8 encoding

This is also fixed in Phobos1.