Bug 3919 – ICE(expression.c, 9944): * or / with typedef ireal

Status
RESOLVED
Resolution
FIXED
Severity
normal
Priority
P2
Component
dmd
Product
D
Version
D2
Platform
x86
OS
Windows
Creation time
2010-03-09T18:01:00Z
Last change time
2014-02-15T02:43:16Z
Keywords
ice-on-valid-code, patch
Assigned to
nobody
Creator
aldonunez1

Comments

Comment #0 by aldonunez1 — 2010-03-09T18:01:17Z
The error is in MulExp::semantic. It happens no matter if the multiplication expression is in a template. These are the combinations that fail: IF * ifloat IF * IF ID * idouble ID * ID IR * ireal IR * IR Here's a sample: import std.stdio; typedef ifloat IF; typedef idouble ID; typedef ireal IR; template PrintAddedType(X, Y) { void PrintAddedType() { X x; Y y; writeln( typeid( x ), " ", typeid( y ), " ", typeid( x * y ) ); } } template PrintAddedType(X) { void PrintAddedType() { /* PrintAddedType!(X, ifloat)(); PrintAddedType!(X, idouble)(); PrintAddedType!(X, ireal)(); */ /* PrintAddedType!(X, IF)(); PrintAddedType!(X, ID)(); PrintAddedType!(X, IR)(); */ } } void main() { /* PrintAddedType!(IF)(); PrintAddedType!(ID)(); PrintAddedType!(IR)(); */ IR x; IR y; writeln( typeid( x ), "\t", typeid( y ), "\t", typeid( x * y ) ); }
Comment #1 by clugdbug — 2010-03-10T23:56:01Z
Applies to D1 as well. Reduced test case for test suite, for both this bug and the next one: ------- typedef ireal BUG3919; alias typeof(BUG3919.init*BUG3919.init) ICE3919; alias typeof(BUG3919.init/BUG3919.init) ICE3920; ------- Simple: It's not obtaining the base type before checking if it is an imaginary type. PATCH: Expression.c MulExp::semantic, around line 9935. Apply exactly the same to DivExp::semantic, around line 10003, to fix bug 3920. if (!e1->isArrayOperand()) e1->checkArithmetic(); if (!e2->isArrayOperand()) e2->checkArithmetic(); if (type->isfloating()) - { Type *t1 = e1->type; - Type *t2 = e2->type; + { Type *t1 = e1->type->toBasetype(); + Type *t2 = e2->type->toBasetype();
Comment #2 by bugzilla — 2010-03-12T20:52:58Z
changeset 415
Comment #3 by clugdbug — 2010-04-09T13:40:06Z
Fixed DMD1.058 and 2.042.