Bug 4437 – copy construction bug with "return this;"

To reproduce, run this on Linux from the Phobos dir (after I'll check std.container in): make unittest BUILD=debug DMDEXTRAFLAGS="-debug=RefCounted -version=bugxxxx" where xxxx is the number of this bug. Basically in a range containing a type with an elaborate copy constructor, this works: Range save() { auto copy = this; return copy; } but this doesn't: Range save() { return this; }

Reduced test case: -------------------- test.d void main() { S s; auto t = s.copy(); assert(t.count == 1); // (5) } struct S { int count; this(this) { ++count; } S copy() { return this; } } -------------------- % dmd -run test.d core.exception.AssertError@test(5): Assertion failure --------------------

I'm 99% sure this is a dup of bug 3516 or together they form the basis of a more general ticket: structs and their postblit and dtors are just mostly unimplmented.

Following patch fixes this bug. src/s2ir.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/s2ir.c b/src/s2ir.c index 08d802b..982adfc 100644 --- a/src/s2ir.c +++ b/src/s2ir.c @@ -1247,7 +1247,7 @@ void ReturnStatement::toIR(IRState *irs) */ Type *tb = exp->type->toBasetype(); //if (tb->ty == Tstruct) exp->dump(0); - if ((exp->op == TOKvar || exp->op == TOKdotvar || exp->op == TOKstar) && + if ((exp->op == TOKvar || exp->op == TOKdotvar || exp->op == TOKstar || exp->op == TOKthis) && tb->ty == Tstruct) { StructDeclaration *sd = ((TypeStruct *)tb)->sym; if (sd->postblit)

Great fix! I changed my votes to vote this...

*** Issue 6195 has been marked as a duplicate of this issue. ***