Bug 4486 – CodeView debug info should contain absolute path names
Status
RESOLVED
Resolution
FIXED
Severity
normal
Priority
P2
Component
dmd
Product
D
Version
D2
Platform
Other
OS
Windows
Creation time
2010-07-19T11:22:00Z
Last change time
2015-06-09T05:12:02Z
Assigned to
nobody
Creator
r.sagitario
Comments
Comment #0 by r.sagitario — 2010-07-19T11:22:00Z
As of DMD 2.047, the CodeView debug information contains file names as specified on the command line, i.e. most of the time relative paths.
According to the omf-specification, the full path should be specified in the THEADR record. This makes it much easier for debuggers to find the correct source modules and can avoid ambiguities.
Here's a patch (filespec.c only contains an unusable version of making a path absolute):
Index: cgobj.c
===================================================================
--- cgobj.c (revision 576)
+++ cgobj.c (working copy)
@@ -17,6 +17,7 @@
#include <stdlib.h>
#include <malloc.h>
#include <ctype.h>
+#include <direct.h>
#include "filespec.h"
@@ -1249,7 +1250,20 @@
void obj_theadr(const char *modname)
{ char *theadr;
int i;
+ char absname[260];
+ if(modname[0] != '\\' && modname[0] != '/' && !(modname[0] && modname[1] == ':'))
+ {
+ if(getcwd(absname, sizeof(absname)))
+ {
+ int len = strlen(absname);
+ if(absname[len - 1] != '\\' && absname[len - 1] != '/')
+ absname[len++] = '\\';
+ strcpy(absname + len, modname);
+ modname = absname;
+ }
+ }
+
//printf("obj_theadr(%s)\n", modname);
theadr = (char *)alloca(ONS_OHD + strlen(modname));
i = obj_namestring(theadr,modname);