Bug 4493 – Add sorting capability to toJSON

Status
RESOLVED
Resolution
FIXED
Severity
enhancement
Priority
P2
Component
phobos
Product
D
Version
D2
Platform
All
OS
All
Creation time
2010-07-22T13:43:00Z
Last change time
2014-09-09T09:23:13Z
Keywords
pull
Assigned to
andrej.mitrovich
Creator
kroeplin.d

Attachments

IDFilenameSummaryContent-TypeSize
694json-unittest.dreplacement for unittest of std.jsonapplication/octet-stream2207

Comments

Comment #0 by kroeplin.d — 2010-07-22T13:43:13Z
Created attachment 694 replacement for unittest of std.json The only non-trivial unittest is commented out as "currently broken". This is confusing: in fact, not the implementation but only the unittest is broken. The reason is, that the order of the name/value pairs in a JSON object is unspecified: the serialization uses foreach(name, member; value.object)! The example just before the "currently broken" one is {"a":1,"b":null}: as the result could also be {"b":null,"a":1}, this test is broken in theory, but not (yet) in practice. Please, consider to replace the broken unittest with the attached proposal.
Comment #1 by kroeplin.d — 2010-07-26T12:15:41Z
assert(find(json, result) != null, text(result, " should be in ", json)); should have been assert(!find(json, result).empty, text(result, " should be in ", json));
Comment #2 by andrej.mitrovich — 2014-04-24T15:43:53Z
Comment #3 by github-bugzilla — 2014-09-09T09:23:13Z
Commits pushed to master at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/374b6e03e724fe3da02093aa0665112135df861c Fix Issue 4493 - Add sorting capability to toJSON and add another unittest. https://github.com/D-Programming-Language/phobos/commit/8b851030f2bd32098e5ae4654e6c2b5082ccee79 Merge pull request #2120 from AndrejMitrovic/Fix4493 Issue 4493 - Add sorting capability to toJSON and add another unittest