Bug 4796 – std.array.appender changes broke dmd unit test runnable/untag.d

To reproduce, from the dmd test dir: make test_results/runnable/untag.d.out The errors: runnable/untag.d(105): Error: template std.array.appender(A : E[],E) does not match any function template declaration runnable/untag.d(105): Error: template std.array.appender(A : E[],E) cannot deduce template function from argument types !()(string*)

It's because appender() no longer takes a pointer.

Don is correct, I changed the interface of appender to be safer (not use pointers to most likely stack variables). Changing bug component to dmd, since this is a dmd test issue, not a phobos issue. Here is a patch. I tried to test it but I get the ominous "no object.d error" I have no patience to try and understand what your test harnesses are doing, so I'll let you figure out if this works or not: Index: runnable/untag.d =================================================================== --- runnable/untag.d (revision 657) +++ runnable/untag.d (working copy) @@ -101,9 +101,9 @@ "Could not find closing tag: "~txt); } } else { - string code; - findConsume(txt, ';', appender(&code)); - switch (code) { + auto app = appender!string(); + findConsume(txt, ';', app); + switch (app.data) { case "#160;": case "#32;": case "reg;": case "nbsp;": writeChar(' '); break; @@ -120,7 +120,7 @@ writeChar('"'); break; default: - throw new Exception(text("Unknown code: &", code)); + throw new Exception(text("Unknown code: &", app.data)); break; } }

(In reply to comment #2) > Changing bug component to dmd, since this is a dmd test issue, not a phobos issue. It's not a dmd bug. Might as well use the dstress component for this! (Can we rename that tag?)

Fix committed in dmd r658. Quibbling about which component it should be assigned to is really petty. Change in phobos caused the dmd test suite to fail. That's what was important.