I'm trying to describe an opcode layout - the arrangement of bits used by a CPU - and the resulting description is generally a union of bitfields:
opcode, displacement
opcode, register, register, register
opcode, constant
...etc
In my case, the opcode represents a common prefix, which leaves me declaring something like this in D:
opcode, displacement
"", register, register, register
"", constant
I would prefer, for reasons of clarity, to be able to repeat the declaration of opcode - the best comment is source code, as it were.
So I would like the bitmanip code to permit redeclaration of bitfields that are identical in all respects.
That is, obviously the names are the same, but the field width, offset, and type representation has to be the same as well.
Comment #1 by bearophile_hugs — 2010-09-24T18:46:51Z
See also bug 4425
Comment #2 by rtcvb32 — 2012-07-31T19:11:09Z
> Also, I think I'm going to request that repeated bitfield definitions be
> allowed if they are identical - I'd like to redeclare "opcode" rather than "".
How would you tell them apart? If i know how you may want to call them, i may be able to make something. I can understand with registers, but still need some way to work with them. Perhaps as a set then?
> So I would like the bitmanip code to permit redeclaration of bitfields that
> are identical in all respects.
>That is, obviously the names are the same, but the field width, offset, and
>type representation has to be the same as well.
Maybe....?
struct S {
mixin(bitfields!(
uint, "opcode", 4,
uint, "register", 4,
uint, "register", 4,
uint, "register", 4
));
}
and using the registers would have function signature like...
struct Register {
uint register_1;
uint register_2;
uint register_3;
}
//setters, likely can't be @propery
void register(uint reg1, uint reg2, uint reg3);
void register(uint[] register ...); //maybe?
void register(Register register);
//getter ??
Register register() const;
Or perhaps...
struct S {
mixin(bitfields!(
uint, "opcode", 4,
uint, "reg1", 4,
uint, "reg2", 4,
uint, "reg3", 4
));
mixin(sharedNameSet(
"nameForGetterAndSetter",
"struct name for returning/passing",
"reg1", "reg2", "reg3" //named variables as a set
));
//nameForGetterAndSetter's would be added here, perhaps as above.
}