Bug 5218 – Can't implicitly convert from "abc"w to wchar[3]

... though you can with char. This code also worked in D1. --- void bug5218c(char [3] s) {} void bug5218w(wchar [3] s) {} void bug5218d(dchar [3] s) {} void main() { bug5218c("abc"); bug5218w("abc"w); bug5218d("abc"d); }

PATCH: This is because "abc"w and "abc"d are committed types. If the type is committed, implicit conversions are not performed at all. But this is wrong: they should still allow const/immutable conversions. Index: cast.c =================================================================== --- cast.c (revision 755) +++ cast.c (working copy) @@ -449,8 +449,6 @@ printf("StringExp::implicitConvTo(this=%s, committed=%d, type=%s, t=%s)\n", toChars(), committed, type->toChars(), t->toChars()); #endif - if (!committed) - { if (!committed && t->ty == Tpointer && t->nextOf()->ty == Tvoid) { return MATCHnomatch; @@ -471,7 +469,8 @@ ((TypeSArray *)t)->dim->toInteger()) return MATCHnomatch; TY tynto = t->nextOf()->ty; - if (tynto == Tchar || tynto == Twchar || tynto == Tdchar) + if (tynto == tyn) return MATCHexact; + if (!committed && (tynto == Tchar || tynto == Twchar || tynto == Tdchar)) return MATCHexact; } else if (type->ty == Tarray) @@ -480,7 +479,8 @@ ((TypeSArray *)t)->dim->toInteger()) return MATCHnomatch; TY tynto = t->nextOf()->ty; - if (tynto == Tchar || tynto == Twchar || tynto == Tdchar) + if (tynto == tyn) return MATCHexact; + if (!committed && (tynto == Tchar || tynto == Twchar || tynto == Tdchar)) return MATCHexact; } case Tarray: @@ -497,13 +497,13 @@ case Tchar: case Twchar: case Tdchar: - return m; + if (!committed) + return m; } break; } } } - } return Expression::implicitConvTo(t); #if 0 m = (MATCH)type->implicitConvTo(t);