Bug 5322 – std.math: version(Sparc) should be SPARC
Status
RESOLVED
Resolution
FIXED
Severity
normal
Priority
P2
Component
phobos
Product
D
Version
D2
Platform
Other
OS
Linux
Creation time
2010-12-04T14:52:00Z
Last change time
2010-12-07T16:41:31Z
Keywords
patch, spec
Assigned to
nobody
Creator
ibuclaw
Comments
Comment #0 by ibuclaw — 2010-12-04T14:52:46Z
That seems to be what's used in druntime as the version identifier for SPARC, should adhere to the same in phobos (or, at the very least, agree on a naming convention for all architectures)
ie:
ALPHA, ARM, PPC, MIPS, SPARC, X86, X86_64
vs
Alpha, Arm, Ppc, Mips, Sparc, X86, X86_64
vs
alpha, arm, ppc, mips, sparc, x86, x86_64
I think the first is the most agreeable. :~)
Regards
Patch:
--- phobos-trunk~/phobos/std/math.d 2010-12-03 03:25:12.000000000 +0000
+++ phobos-trunk/phobos/std/math.d 2010-12-04 22:47:59.777486614 +0000
@@ -1948,7 +1948,7 @@
DIVBYZERO_MASK = 0x020,
INVALID_MASK = 0xF80 // PowerPC has five types of invalid exceptions.
}
- } else version(Sparc) { // SPARC FSR is a 32bit register
+ } else version (SPARC) { // SPARC FSR is a 32bit register
//(64 bits for Sparc 7 & 8, but high 32 bits are uninteresting).
enum : int {
INEXACT_MASK = 0x020,