← Back to index | Original Bugzilla link

Bug 5330 – Druntime/Phobos: remove special treatment for GDC

Status: RESOLVED
Resolution: FIXED
Severity: normal
Priority: P2
Component: phobos
Product: D
Version: D2
Platform: x86
OS: All
Creation time: 2010-12-07T03:43:00Z
Last change time: 2015-06-09T05:12:03Z
Keywords: patch
Assigned to: nobody
Creator: ibuclaw

Attachments

ID	Filename	Summary	Content-Type	Size
842	phobos-version-asm.patch	Remove version(GNU){} else { version=ASMx86 } code	text/plain	2003

Comments

Comment #0 by ibuclaw — 2010-12-07T03:43:42Z

There are various bits of code in and around Druntime and Phobos that hide inline asm from GDC (or when version = GNU). In my opinion, I think these should be removed as they only hide GDC bugs that *should* instead be fixed in the compiler. Regards

Comment #1 by ibuclaw — 2010-12-07T03:53:25Z

Created attachment 842 Remove version(GNU){} else { version=ASMx86 } code Patch to remove it from the notable places in core.cpuid and std.math. Regards

Comment #2 by clugdbug — 2010-12-07T06:14:12Z

I've wanted to do that for years. Thanks! http://www.dsource.org/projects/druntime/changeset/439 http://www.dsource.org/projects/phobos/changeset/2210

Comment #3 by ibuclaw — 2010-12-07T07:17:41Z

:3 Incase you are curious, GDC still can't generate the correct codegen for the naked asm inside exp2 and expm1. But then again, the GCC builtin functions make a better replacement of them for the time being.