Bug 5375 – Detection of cyclic module imports provides error findings on console, instead of exception msg

Status
RESOLVED
Resolution
FIXED
Severity
normal
Priority
P2
Component
druntime
Product
D
Version
D2
Platform
Other
OS
Windows
Creation time
2010-12-25T11:26:00Z
Last change time
2013-02-05T11:40:31Z
Keywords
pull
Assigned to
andrej.mitrovich
Creator
michal.minich

Comments

Comment #0 by michal.minich — 2010-12-25T11:26:18Z
from object_.d: > // print the cycle > println("Cycle detected between modules with ctors/dtors:"); > foreach(cm; dtors[dtoridx..$]) > { > console(cm.name)(" -> "); > } > println(cycleModule.name); > throw new Exception("Aborting!"); for non-console application, it is hard to find what is happening, except "Aborting!" (adding AttachConsole(-1) call is needed, moreover this function is not included in druntime win bindings) All the cycle printing text should be included in exception message. (I see no problem printing it on console too)
Comment #1 by andrej.mitrovich — 2012-12-18T15:07:50Z
Comment #2 by github-bugzilla — 2012-12-18T19:19:48Z
Commits pushed to master at https://github.com/D-Programming-Language/druntime https://github.com/D-Programming-Language/druntime/commit/84d60f5e599b9aca80afb782c24f5a9de568278c Fix Issue 5375 - Cyclic error should be embedded in the exception. https://github.com/D-Programming-Language/druntime/commit/ffd252c07e7dc1f8adc5384cc1d1e3351d063ead Merge pull request #365 from AndrejMitrovic/Fix5375 Issue 5375 - Cyclic error message should be embedded in the Exception.