Bug 5462 – std.container.BinaryHeap enforce message + pop

A D2 program: import std.container; void main() { auto h = BinaryHeap!(int[])([]); h.removeFront(); } It throws the exception: object.Exception@...\dmd\src\phobos\std\container.d(2592): Enforcement failed In a larger program such error message is bad because it doesn't give a lot of information. To improve the situation a little I suggest to modify the enforce at line 2592: void removeFront() { enforce(!empty); Adding an error message that helps understand what the error is: enforce(!empty, "Attempt to remove the front of an empty heap"); (The future stack trace on Windows will probably also give the line number 4 of the user program.) ------------------------- In code that uses the BinaryHeap I've often used two lines of code like this: auto item = heap.front(); heap.removeFront(); So I suggest to add to BinaryHeap a handy member function pop() that does both things: auto item = heap.pop();

Commits pushed to master at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/d7628ec0a0241c92a129e51de6702380513e2535 Fix Issue 5462 - Better errors in BinaryHeap Added descriptive errors to the enforces and asserts inside BinaryHeap. https://d.puremagic.com/issues/show_bug.cgi?id=5462 https://github.com/D-Programming-Language/phobos/commit/b402145a768c5a80b64d63215f18a2d1493f9a58 Merge pull request #1882 from Poita/bug5462 Fix Issue 5462 - Better errors in BinaryHeap

Is the heap.pop(); a WONTFIX?

Sorry, missed that. (would probably be better if this was two separate enhancements)

(In reply to comment #3) > Sorry, missed that. > > (would probably be better if this was two separate enhancements) Yes, this ER is from some years ago, and since then I've learnt to avoid packing two or more enhancements or bug reports in the same issue report, unless they are really tied together. So I close this issue again, and split it into another (but I remember some issues against the idea of having a pop() function in C++).