Bug 6099 – std.windows.registry exposes too much implementation details

Status
RESOLVED
Resolution
FIXED
Severity
normal
Priority
P2
Component
phobos
Product
D
Version
D2
Platform
Other
OS
Windows
Creation time
2011-06-03T07:49:00Z
Last change time
2012-12-10T15:37:26Z
Assigned to
nobody
Creator
kai

Attachments

IDFilenameSummaryContent-TypeSize
992registry.diffHide implementation details in std.windows.registryapplication/octet-stream3684

Comments

Comment #0 by kai — 2011-06-03T07:49:03Z
Created attachment 992 Hide implementation details in std.windows.registry The program import core.sys.windows.windows; import std.windows.registry; void main() { auto error = GetLastError(); } causes an error because GetLastError() is declared and exported from both modules. Personally, I do not expect such conflicts from a library. The root cause is that std.windows.registry exposes too much implementation details. The attached patch changes the following: - The windows API functions are not exported - Windows API functions duplicated from core.sys.windows.windows are removed - Type boolean is replaced by standard bool
Comment #1 by andrei — 2011-06-03T07:52:05Z
Thanks! Any chance you could submit your patch as a pull request to https://github.com/D-Programming-Language/phobos/pulls?
Comment #2 by kai — 2011-06-03T11:02:03Z