Bug 6496 – Fix std.process.browse per comments in pull request #154

Status
RESOLVED
Resolution
FIXED
Severity
normal
Priority
P2
Component
phobos
Product
D
Version
D2
Platform
All
OS
All
Creation time
2011-08-14T12:34:13Z
Last change time
2024-10-22T02:31:08Z
Assigned to
No Owner
Creator
Jonathan M Davis
See also
https://issues.dlang.org/show_bug.cgi?id=24824, https://issues.dlang.org/show_bug.cgi?id=24825

Comments

Comment #0 by issues.dlang — 2011-08-14T12:34:13Z
Due to the fact that Walter made the changes but I made the pull request, it ended up getting pulled in without adjustments to it being made as should probably have occurred. The feedback in the pull requests still needs to be applied to the code. I'm creating this issue so that it doesn't get forgotten. https://github.com/D-Programming-Language/phobos/pull/154
Comment #1 by lt.infiltrator — 2014-03-19T19:22:17Z
Jonathan, did you end up forgetting about this? :P
Comment #2 by issues.dlang — 2014-03-19T21:45:33Z
> Jonathan, did you end up forgetting about this? :P Yes, though the bug was created so that we as a community would have a note to take care of this and thus remember to. Anyone is free to do this. I just happen to be the one who took the initiative to open the bug report. It's a weird situation, because I ended up creating a pull request for Walter's code. But clearly this bug report served its purpose, because you found it and brought thus brought it up again. It would have been completely forgotten otherwise. I still probably should have remembered this and taken care of it by now, but anyone is free to do so.
Comment #3 by lt.infiltrator — 2014-03-19T21:51:43Z
Good point about this bug report. Since you know the situation better than I, could you please list here which changes actually need to be made?
Comment #4 by b2.temp — 2017-12-20T21:45:29Z
Current version of browse shows that comments have been addressed - windows version use the ShellExecuteW() and not the A anymore - OSX use open() if the code using $BROWSER didn't work