Bug 6571 – typedefs ignore const, shared, immutable etc modifiers when implicitly converting

The following compiles without error on dmd2.055 head, although it includes casting shared(void*) to void* and const(void*) to void*. alias doesn't not have the same problems. void main() { typedef void* A; void AA(A a) {} shared A a; const A b; AA(a); AA(b); }

I think this should sort it: MATCH TypeTypedef::constConv(Type *to) { if (equals(to)) return MATCHexact; - if (ty == to->ty && sym == ((TypeTypedef *)to)->sym) - return sym->basetype->implicitConvTo(((TypeTypedef *)to)->sym->basetype); + if (ty == to->ty && sym == ((TypeTypedef *)to)->sym && + MODimplicitConv(mod, to->mod)) + return MATCHconst; return MATCHnomatch; } Regards

Patch breaks std.encoding: std/encoding.d:373: Error: cannot implicitly convert expression (s[0u]) of type const(AsciiChar) to AsciiChar std/encoding.d:374: Error: cannot implicitly convert expression (s[0u]) of type const(AsciiChar) to AsciiChar std/encoding.d:380: Error: cannot implicitly convert expression (s[__dollar - 1u]) of type const(AsciiChar) to AsciiChar std/encoding.d:381: Error: cannot implicitly convert expression (s[__dollar - 1u]) of type const(AsciiChar) to AsciiChar Other than that, it is all good to go. :)

It should break std.windows.registry too, that's where I found it.

I don't have windows so I can't test that. ;) Everything is fine on the *nix side of things. For std.encoding, just replace the three 'typedef ubyte' with 'alias ubyte xxx' Regards

(In reply to comment #4) > I don't have windows so I can't test that. ;) > Since phobos and druntime don't use typedef any more, there should be no reliance on this bug any more. Would you like to make a pull request? > Everything is fine on the *nix side of things. For std.encoding, just replace > the three 'typedef ubyte' with 'alias ubyte xxx' This didn't work for me for some reason, I think the module relies on them being distinct types. Using enums instead solved the problem.

A related issue is if const is part of the typedef. typedef const(void*) type; void bar(void* a) {} void main() { type a; bar(&a); }

First off, this is a D2, not a D1 issue. D

... continued D1 does not have shared/const, etc. Secondly, typedefs are deprecated in D2. So this is "wontfix".