Bug 6666 – gc finalization/freeing is hierarchy agnostic

Status
RESOLVED
Resolution
INVALID
Severity
normal
Priority
P3
Component
druntime
Product
D
Version
D2
Platform
Other
OS
All
Creation time
2011-09-13T17:58:00Z
Last change time
2011-09-13T21:18:40Z
Assigned to
nobody
Creator
code

Comments

Comment #0 by code — 2011-09-13T17:58:47Z
class A { ~this() {} void cleanup() {} } class B { this(A a) { this.a = a; } ~this() { a.cleanup(); } A a; } void main() { auto a = new A(); auto b = new B(a); // allocating a at a lower address than b causes it to be finalized earlier assert(cast(void*)b.a < cast(void*)b); } --- Finalization is done in memory order and does not take hierarchies into account. When b.a is finalized before b it's vtable is set to null, hence a segfault will happen when accessing the vtable. Anyhow a is destroyed before b even though it is referenced by b. It seems like we need to somehow sort the to be finalized memory while scanning. Any cheap ideas to do that are welcome.
Comment #1 by dlang-bugzilla — 2011-09-13T18:04:22Z
This is known, documented behavior. From http://www.d-programming-language.org/class.html#destructors : > Furthermore, the order in which the garbage collector calls destructors for unreference objects is not specified. This means that when the garbage collector calls a destructor for an object of a class that has members that are references to garbage collected objects, those references may no longer be valid. This means that destructors cannot reference sub objects. (In reply to comment #0) > It seems like we need to somehow sort the to be finalized memory while > scanning. What about cyclic references?
Comment #2 by dlang-bugzilla — 2011-09-13T18:05:56Z
Oops, I broke it. > Furthermore, the order in which the garbage collector calls destructors > for unreference objects is not specified. This means that when the garbage > collector calls a destructor for an object of a class that has members that > are references to garbage collected objects, those references may no longer > be valid. This means that destructors cannot reference sub objects.
Comment #3 by code — 2011-09-13T21:18:40Z
Surprise, surprise. Seems like there is not much one can reliably do in a finalizer. Anyhow it was motivated by a C++ habit to do some clean up.