Bug 6993 – File.byLine runs on an empty file, fails enforcement
Status
RESOLVED
Resolution
DUPLICATE
Severity
major
Priority
P2
Component
phobos
Product
D
Version
D2
Platform
Other
OS
Windows
Creation time
2011-11-22T21:04:00Z
Last change time
2011-11-23T09:26:47Z
Assigned to
nobody
Creator
andrej.mitrovich
Comments
Comment #0 by andrej.mitrovich — 2011-11-22T21:04:53Z
Create a new file "empty.d" and run this:
import std.stdio;
void main()
{
auto file = File("empty.d", "r");
foreach (aLine; file.byLine)
{
}
}
object.Exception@D:\DMD\dmd2\windows\bin\..\..\src\phobos\std\stdio.d(943): Enforcement failed
Line 943:
enforce(file.isOpen);
So the file was not successfully opened, but why wasn't an exception thrown in the File constructor then?
Comment #1 by issues.dlang — 2011-11-22T21:49:06Z
I don't see any reason why an exception would be thrown from File's constructor for an empty file. It certainly doesn't say that it does. The problem is that ByLine clearly isn't set up to handle empty files correctly.
Duplicate of Bug# 6944
*** This issue has been marked as a duplicate of issue 6944 ***
Comment #2 by andrej.mitrovich — 2011-11-23T09:15:25Z
(In reply to comment #1)
> I don't see any reason why an exception would be thrown from File's constructor
> for an empty file. It certainly doesn't say that it does. The problem is that
> ByLine clearly isn't set up to handle empty files correctly.
>
> Duplicate of Bug# 6944
>
> *** This issue has been marked as a duplicate of issue 6944 ***
I agree, but the file handle was closed so I *assumed* that meant the file was not opened. I would rather have byLine not iterate than throw just because a file is empty.
Comment #3 by issues.dlang — 2011-11-23T09:26:47Z
Oh. I agree completely. I think that byLine should just be empty when the file is empty, so no iteration occurs. I don't know what the exact details of opening the file are, but I don't see why an empty file should throw when you try and open it. Certainly, File's docs don't say anything of the sort. In Linux however, I ended up hitting an assertion rather than the exception that you hit, so there may be system-dependent behavior going on.