Bug 7182 – Call const or immutable member functions from class invariant

Status
RESOLVED
Resolution
INVALID
Severity
enhancement
Priority
P2
Component
dmd
Product
D
Version
D2
Platform
Other
OS
All
Creation time
2011-12-29T06:17:00Z
Last change time
2017-06-26T14:51:19Z
Assigned to
nobody
Creator
full.demon

Comments

Comment #0 by full.demon — 2011-12-29T06:17:44Z
The following code yields an error: class A { public: int f() const { return 5; } protected: invariant() { assert (f() == 5); } } "Error: cannot call public/export function f from invariant" Why? f() is const and cannot change the state of an instance of A. Invariant checks are redundant around const/immutable public member functions. What if 'this' was passed to the member function?
Comment #1 by lt.infiltrator — 2014-03-19T22:38:31Z
I think that the issue would instead be with the fact that public functions (f() in this case) call invariant() before and after they run, which would result in an infinite loop. I therefore think that this should be closed as INVALID. Any of you big guns want to weigh in on this?
Comment #2 by dlang-bugzilla — 2017-06-26T14:51:19Z
(In reply to Infiltrator from comment #1) > I think that the issue would instead be with the fact that public functions > (f() in this case) call invariant() before and after they run, which would > result in an infinite loop. Pretty sure your explanation is correct. Although one may argument in favor of making const methods not cause invariant checks, that would mean that e.g. getters are no longer protected by invariants, should something modify the object's state into an invalid one directly (e.g. by writing to fields).