Bug 7303 – Erroneous closure behavior

Status
RESOLVED
Resolution
DUPLICATE
Severity
normal
Priority
P2
Component
dmd
Product
D
Version
D2
Platform
Other
OS
Linux
Creation time
2012-01-17T05:14:00Z
Last change time
2012-11-12T02:42:25Z
Assigned to
nobody
Creator
dpx.infinity

Comments

Comment #0 by dpx.infinity — 2012-01-17T05:14:16Z
Consider this code: module test; import std.stdio; class C { public int x; this(int x) { this.x = x; } } void delegate() test(int n) { C c = new C(n); void inner() { writeln(c.x); } return () { inner(); }; } void main(string[] args) { auto d1 = test(12); auto d2 = test(13); d1(); d2(); } It prints 13 two times, though it should print first 12, then 13. I found this problem while trying to create simple test case for the following similar closure-related error. I'm using gtkd to create UI for my program. This code TextBuffer logBuffer = logTextView.getBuffer(); void logln(string s) { TextIter it = new TextIter(); logBuffer.getEndIter(it); logBuffer.insert(it, s ~ "\n"); } auto computeHandler = (Button aux) { logln("Compute pressed."); }; auto singlePlotHandler = (Button aux) { logln("Single pressed."); }; auto comparePlotHandler = (Button aux) { logln("Compare pressed."); }; segfaults when any of the *Handler closures are called (from the gtk event handling code). This happens because logBuffer variable used in logln function is null, though it shouldn't. If I use logBuffer in any way in any of the closures, the code works fine. It seems that there's a problem in closed variables detection in both programs. In simple test case it does not crash the program because of its simplicity, but in the second one stack is overwritten many times after the delegates are created, so no wonder it fails. I'm using dmd v2.057 on x86_64 linux system.
Comment #1 by clugdbug — 2012-01-17T07:54:43Z
Duplicate of bug 1841?
Comment #2 by verylonglogin.reg — 2012-11-12T02:38:43Z
(In reply to comment #1) > Duplicate of bug 1841? Yes. The closure isn't detected. Writing `&c` from `test.inner` showsw it is on stack but must be in heap.
Comment #3 by verylonglogin.reg — 2012-11-12T02:39:46Z
(In reply to comment #1) > Duplicate of bug 1841? Yes. The closure isn't detected. Writing `&c` from `test.inner` showsw it is on stack but must be in heap.
Comment #4 by verylonglogin.reg — 2012-11-12T02:42:25Z
*** This issue has been marked as a duplicate of issue 1841 ***