Bug 7374 – stdin.byLine() throws AssertError on empty input

Status
RESOLVED
Resolution
FIXED
Severity
normal
Priority
P2
Component
phobos
Product
D
Version
D2
Platform
x86_64
OS
Linux
Creation time
2012-01-26T12:16:00Z
Last change time
2012-02-24T11:11:55Z
Assigned to
nobody
Creator
hsteoh

Comments

Comment #0 by hsteoh — 2012-01-26T12:16:45Z
Here's the test program: import std.stdio; void main() { foreach (line; stdin.byLine()) { writeln("Got input line: ", line); } } When the program is run on an empty input (e.g., running 'echo -n | program' in the shell, or hitting ctrl-D once the program starts up, or piping an empty file to the program), an assertion fails: core.exception.AssertError@/usr/include/d2/4.6/std/stdio.d(989): Bug in File.readln It appears that the problem is caused by one of two things: (1) ByLine.empty() assuming that as long as a file is open it will have at least 1 line, but this is not true when the input is 0 bytes. (2) stdin.readln() returns null if the input has 0 bytes, instead of a line of 0 length (which is what it does at EOF if the input is *not* empty).
Comment #1 by andrei — 2012-02-23T16:23:00Z
I think https://github.com/D-Programming-Language/phobos/commit/94b21d38d16e075d7c44b53015eb1113854424d0 fixes this, could you please double-check? On OSX the test program works as expected.
Comment #2 by hsteoh — 2012-02-24T10:52:15Z
I couldn't figure out how to make git phobos work with gdc, but I managed to build latest git dmd/druntime/phobos and run the test program on it, now it seems to work. So this bug can probably be closed.