Comment #0 by leandro.lucarella — 2012-03-21T05:25:44Z
How to reproduce:
---
echo 'class C { void asdfg() {} }' > inc.d
echo 'import inc; void f(C c) { auto x = &c.asdfg; }' > m.d
dmd -c -release -inline m.d ; nm m.o
---
This prints:
---
00000000 t
U _D10ModuleInfo6__vtblZ
00000000 D _D1m12__ModuleInfoZ
00000000 T _D1m1fFC3inc1CZv
00000000 T _D3inc1C5asdfgMFZv
U _Dmodule_ref
---
Which means that _D3inc1C5asdfgMFZv (AKA inc.asdfg()) is included in the text (code) section of m.o, but it shouldn't, it should only be in inc.d (which I didn't even compile), otherwise when linking both inc.o and m.o you'll get a "multiple definition" error. Symbol D3inc1C5asdfgMFZv should have U (undefined) or maybe at most v/W (weak linkage).
Please note that the compiler flags -inline -release has to be used to reproduce the bug, removing either makes it go away. -O is irrelevant.
This regression was introduced by commit 415e48ac4703ffab94cd6ce5a3211625099c637a in D1, which is the fix for bug 4820.
This bug prevents using Tango, so I guess it should be high priority among regressions (reverting the fix for bug 4820 in the latest dmd-1.x branch fixes the problem, and I think is even better to leave that bug unfixed instead of introducing this new regression).
Comment #1 by clugdbug — 2012-03-21T12:27:57Z
I haven't been able to reproduce this. If I change it from:
-auto x = &c.asdfg;
+auto x = &C.asdfg;
then I get a U symbol for _D3inc1C5asdfgMFZv, otherwise I can't get it to appear at all. I guess it is changed into an index into the vtable.
Further investigation required.
Comment #2 by clugdbug — 2012-03-22T04:08:58Z
Now able to reproduce it. The cause was this line added to e2ir.c, line 3129.
//printf("DelegateExp::toElem() '%s'\n", toChars());
+ if (func->semanticRun == PASSsemantic3done)
+ irs->deferToObj->push(func);
The fact that EVERY delegate expression gets deferred, seems like overkill for the bug being fixed.
Comment #3 by clugdbug — 2012-03-22T05:36:47Z
Reduced test case (actually much longer, but doesn't require -inline -release, and also fails on D2).
inc.d ---------------
struct C { void asdfg() {} }
m.d-----------------------
import inc;
bool forceSemantic7745()
{
C c;
c.asdfg();
return true;
}
static assert(forceSemantic7745());
void f(C c) { auto x = &c.asdfg; }
void main() {}
----
dmd -c inc.d
dmd -c m.d
dmd m.o inc.o
----
inc.o: In function `_D3inc1C5asdfgMFZv':
inc.d:(.text._D3inc1C5asdfgMFZv+0x0): multiple definition of `_D3inc1C5asdfgMFZv'
m.o:m.d:(.text._D3inc1C5asdfgMFZv+0x0): first defined here
It happens because this has forced asdfg() to be semantically analyzed. I'm using CTFE to do this, there are probably more direct ways.
PATCH (D2, also works for D1):
-- a/src/e2ir.c
+++ b/src/e2ir.c
@@ -3422,7 +3422,8 @@ elem *DelegateExp::toElem(IRState *irs)
//printf("DelegateExp::toElem() '%s'\n", toChars());
- if (func->semanticRun == PASSsemantic3done)
+ if (func->semanticRun == PASSsemantic3done
+ && func->parent == irs->m ) // bug 7745
{
irs->deferToObj->push(func);
}
The idea of the patch is that it should only write to the obj file if the parent of the function belongs to this module.
Not sure if this is correct, but at least it still fixes the test case in 4820.
Perhaps it should run through all parents until it gets to the module.
Comment #4 by github-bugzilla — 2012-03-28T22:54:42Z