Bug 7819 – std.file.setTimes throws error on folders

std.file.setTimes threw an error on folder names while it worked ok on regular files. Not sure if it is an error since there is no documentation that it shouldn't work for folders. Should it work, or what is the alternative? In the lines below, am.time was from std.zip archive entry. tz was from localTime(). fullPathname is a full path to a windows directory name. SysTime st = DosFileTimeToSysTime(am.time, tz); std.file.setTimes(fullPathname, st, st);

It looks like CreateFile requires a special flag, FILE_FLAG_BACKUP_SEMANTICS , in order to get a handle from a directory that can be used with the SetFileTime call. Below is an excerpt from a discussion on the topic. http://cygwin.com/ml/cygwin/1997-12/msg00350.html Windows NT: You can obtain a handle to a directory by calling the CreateFile function with the FILE_FLAG_BACKUP_SEMANTICS flag set, as follows: hDir = CreateFile ( DirName, GENERIC_READ, FILE_SHARE_READ|FILE_SHARE_DELETE, NULL, OPEN_EXISTING, FILE_FLAG_BACKUP_SEMANTICS, NULL ); You can pass a directory handle to the following SetFileTime function.

I tried the mod below in the setTimes code in 2.058 std.file and it now will permit both file and directory timestamp updates with no thrown errors. The only changes are to line 2788 where I added the FILE_ATTRIBUTE_DIRECTORY and FILE_FLAG_BACKUP_SEMANTICS attributes, and a few lines prior adding FILE_SHARE_READ|FILE_SHARE_DELETE, as suggested in the other discussion. I tested using this change to restore timestamps on all files and folders in an unzipped 2GB directory with no issues. else void setTimes(C)(in C[] name, SysTime fileAccessTime, SysTime fileModificationTime) if(is(Unqual!C == char)) { version(Windows) { const ta = SysTimeToFILETIME(fileAccessTime); const tm = SysTimeToFILETIME(fileModificationTime); alias TypeTuple!(GENERIC_WRITE, FILE_SHARE_READ|FILE_SHARE_DELETE, null, OPEN_EXISTING, FILE_FLAG_BACKUP_SEMANTICS|FILE_ATTRIBUTE_NORMAL|FILE_ATTRIBUTE_DIRECTORY, HANDLE.init)

(In reply to comment #3) > https://github.com/D-Programming-Language/phobos/pull/1128 Thanks for the patch Jay Norwood!

Commits pushed to master at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/26edcdd305b25c3fae7fdf54ebe9768a554c9aa8 Fixes Issue 7819 - setTimes should work on folders. https://github.com/D-Programming-Language/phobos/commit/ad80aef23e54a9f9b4eec32e21016365b7b0f9b4 Merge pull request #1128 from AndrejMitrovic/Fix7819 Issue 7819 - setTimes should support folders on Windows

Commit pushed to staging at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/dc32bd2595d2dfcd7b1f50375a80fd58307fd8dc Fixes Issue 7819 - setTimes should work on folders.