Bug 8101 – Display candidate function overloads when function call fails

int foo(int); int foo(int, int); void main() { foo(); } DMD 2.060alpha gives: test.d(4): Error: function test.foo (int) is not callable using argument types () test.d(4): Error: expected 2 function arguments, not 0 But a better error message tells that foo() has two overloads, and both are (in this case) not fitting for a zero arguments call. A possible single error message: test.d(4): no function overloads test.foo matching argument types (). Only test.foo(int) and test.foo(int, int) are defined.

Commits pushed to master at https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/94eb61432e9f1ad40af4118e6b44af6cb59565db Fix Issue 8101 - Display candidate function overloads when function call fails. https://github.com/D-Programming-Language/dmd/commit/58445fb12bc4043091b42c5b25359023e7f94704 Merge pull request #3508 from AndrejMitrovic/Fix8101 Issue 8101 - Display candidate function overloads when function call fails.

The example code: int foo(int); int foo(int, int); void main() { foo(); } Now gives: temp.d(4,8): Error: function temp.foo (int) is not callable using argument types (), candidates are: temp.d(1,5): temp.foo(int) temp.d(2,5): temp.foo(int, int) What's the point of writing "function temp.foo (int)"? If there are overloads and none of them is fitting for the given arguments in the call, then I think it's not useful to show one of the overloads there. So I think a better error message is: temp.d(4,8): Error: overloaded function temp.foo is not callable using argument types (), candidates are: temp.d(1,5): temp.foo(int) temp.d(2,5): temp.foo(int, int) But the current situation is acceptable, and it's much better than before, so this doesn't matter much.

(In reply to bearophile_hugs from comment #3) > What's the point of writing "function temp.foo (int)"? Yes, that's a good point. I'll make a fixup.

(In reply to Andrej Mitrovic from comment #4) > (In reply to bearophile_hugs from comment #3) > > What's the point of writing "function temp.foo (int)"? > > Yes, that's a good point. I'll make a fixup. https://github.com/D-Programming-Language/dmd/pull/3520

(In reply to Andrej Mitrovic from comment #4) > (In reply to bearophile_hugs from comment #3) > > What's the point of writing "function temp.foo (int)"? > > Yes, that's a good point. I'll make a fixup. Sorry for finding the problem here instead in the patch examples.

Commits pushed to master at https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/cc37567679adbff60ea11b460c377702b20b133e Fix Issue 8101 - Fixup pull improving diagnostics when there are overloads. https://github.com/D-Programming-Language/dmd/commit/3ddfaad1a1aa1375f306015086b9f024ecf8b560 Merge pull request #3520 from AndrejMitrovic/Fixup8101 Issue 8101 - Fixup pull improving diagnostics when there are overloads present.

Now this code: void foo(int) {} void foo(int, int) {} void bar(float) {} void bar(double) {} void bar(real) {} void main() { foo; bar(1); } Gives: temp.d(7,5): Error: None of the overloads of 'foo' are callable using argument types (), candidates are: temp.d(1,6): temp.foo(int _param_0) temp.d(2,6): temp.foo(int _param_0, int _param_1) temp.d(8,8): Error: temp.bar called with argument types (int) matches both: temp.d(3,6): temp.bar(float _param_0) and: temp.d(5,6): temp.bar(real _param_0) It uses the word "both" and it doesn't list temp.bar(double _param_0) Is this worth opening another ER? :-)

(In reply to bearophile_hugs from comment #8) > Now No, not now, that's how it already was. 2.065: ----- void bar(float) {} void bar(double) {} void bar(real) {} void main() { bar(1); } ----- ----- test.d(5): Error: test.bar called with argument types (int) matches both: test.d(1): test.bar(float _param_0) and: test.d(3): test.bar(real _param_0) ----- File it as a separate bug.

(In reply to Andrej Mitrovic from comment #9) > File it as a separate bug. OK, Issue 12694