Bug 8954 – Missing line number in error message for uncollable destructor/postblit

--- struct S { this(this) { } ~this() { } } struct S2 { const S s; } --- Output: --- Error: destructor main.S.~this () is not callable using argument types () const Error: function main.S.__postblit () is not callable using argument types () const --- Severity is "Critical" as Don write in Issue 5314, comment 10: > They're equivalent to compiler segfaults. Worse than any rejects-valid bug. > They're nearly always very easy to fix, too. There's no excuse for them.

*** Issue 10020 has been marked as a duplicate of this issue. ***

*** Issue 9031 has been marked as a duplicate of this issue. ***

Internal notes for other compiler devs: Offending code for postblits in StructDeclaration::buildPostBlit: ----- Loc loc = Loc(); // internal code should have no loc to prevent coverage ----- Commenting that out fixes it for postblits. For dtors it's in AggregateDeclaration::buildDtor(Scope *sc): ----- Loc loc = Loc(); // internal code should have no loc to prevent coverage ----- I think it can be fixed by adding an 'isInternal' field to the dtor/postblit classes and passing a valid Loc, then cov generation could check isInternal while other diagnostics code doesn't have to be touched. Will try this out.

(In reply to comment #3) > I think it can be fixed by adding an 'isInternal' field to the dtor/postblit > classes and passing a valid Loc, then cov generation could check isInternal > while other diagnostics code doesn't have to be touched. Will try this out. Nevermind, it's actually CallExp which needs the Loc info. Still it's fixable.

This code now compiles successfully.