patch to std.traits.d file for eliminating the dependency over libcurl
text/plain
2918
Comments
Comment #0 by philippe.sigaud — 2013-01-04T07:09:57Z
DMD 2.061:
A std.traits unit test has a pragma(lib, "curl") declaration. That makes
$ rdmd -unittest myfile.d
fail because dmd -deps (called by rdmd) activate the pragma and if the user has no curl installed, this stops the compilation.
Btw,
$ dmd -unittest myfile.d
works OK.
The concerned std.traits unit test should be changed.
Comment #1 by andrej.mitrovich — 2013-01-04T08:08:41Z
*** Issue 9007 has been marked as a duplicate of this issue. ***
Comment #2 by andrej.mitrovich — 2013-01-18T10:19:57Z
*** Issue 9349 has been marked as a duplicate of this issue. ***
Comment #3 by pisetta.gianni — 2013-01-21T11:16:57Z
Created attachment 1181
patch to std.traits.d file for eliminating the dependency over libcurl
Patch that solves the issue of libcurl needed in the unittest of std.traits module replacing the tests with the core.sync.barrier module.
Comment #4 by pisetta.gianni — 2013-01-21T11:22:41Z
I tought that it is incorrect to use a module that needs an external library, so i replaced the use of etc.c.curl module with the core.sync.barrier module, that doesn't need other libraries and i think it is unlikely that that module is changed in the future.
I have attached the patch file generated with diff.
Gianni Pisetta
Comment #5 by andrej.mitrovich — 2013-01-21T11:35:45Z
(In reply to comment #3)
> Created an attachment (id=1181) [details]
> patch to std.traits.d file for eliminating the dependency over libcurl
>
> Patch that solves the issue of libcurl needed in the unittest of std.traits
> module replacing the tests with the core.sync.barrier module.
Thanks. Do you want to make a pull request or should we do it for you?
Comment #6 by andrej.mitrovich — 2013-01-21T17:27:00Z