Bug 9310 – escapeShellCommand unittests are never run

Status
RESOLVED
Resolution
FIXED
Severity
normal
Priority
P2
Component
phobos
Product
D
Version
D2
Platform
All
OS
All
Creation time
2013-01-12T17:34:00Z
Last change time
2013-10-08T18:05:54Z
Keywords
pull
Assigned to
andrej.mitrovich
Creator
andrej.mitrovich

Comments

Comment #0 by andrej.mitrovich — 2013-01-12T17:34:28Z
The unitttests are not run at all for this function, because -version=unittest_burnin is never set in Phobos. Note that running the tests would have prevented the newly discovered compiler regression: http://d.puremagic.com/issues/show_bug.cgi?id=9309 Which was found thanks to this report: http://d.puremagic.com/issues/show_bug.cgi?id=9307 As a result `escapeShellCommand` is completely unusable in 2.061 because it always returns an empty string.
Comment #1 by github-bugzilla — 2013-02-24T16:53:28Z
Commits pushed to master at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/128f1e4f3a5422d893990550b8f5dc26e2d5ea13 std.process: Add an additional unit test for escapeShellCommand (issue 9310) https://github.com/D-Programming-Language/phobos/commit/71079e3901907343c27e5781a6150912782daead Merge pull request #1161 from CyberShadow/std-process-additional-unittest std.process: Add an additional unit test for escapeShellCommand (issue 9310)
Comment #2 by andrej.mitrovich — 2013-09-17T15:44:16Z