Bug 9369 – DDoc hardcodes '&' -> '&' in code

Status
RESOLVED
Resolution
FIXED
Severity
normal
Priority
P2
Component
dmd
Product
D
Version
D2
Platform
All
OS
All
Creation time
2013-01-22T11:38:00Z
Last change time
2013-01-24T16:03:00Z
Assigned to
nobody
Creator
andrei

Comments

Comment #0 by andrei — 2013-01-22T11:38:10Z
Code samples introduced with '----' have all ampersands replaced with '&'. This HTMLism makes it impossible to translate to other document formats.
Comment #1 by bugzilla — 2013-01-22T14:39:14Z
Comment #2 by github-bugzilla — 2013-01-22T15:36:22Z
Commits pushed to master at https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/87ee81ad633dd65274482027b5dcd2d48eefa85f fix Issue 9369 - DDoc hardcodes '&' -> '&' in code https://github.com/D-Programming-Language/dmd/commit/2471fe912b0707e30be3c7b58d5a0f70a0f6a796 Merge pull request #1535 from WalterBright/fix9369 fix Issue 9369 - DDoc hardcodes '&' -> '&' in code
Comment #3 by andrei — 2013-01-23T09:41:29Z
With the new release, attempting to compile the following file crashes dmd: =======dlangspec-tex.d begins here Ddoc --- a=1; --- =======dlangspec-tex.d ends here The command invoked is: dmd dlangspec-tex.d I have updated the compiler, druntime, and phobos, made a clean 64-bit build. Can you reproduce this?
Comment #4 by bugzilla — 2013-01-23T12:28:46Z
Yes, I can reproduce it.
Comment #5 by bugzilla — 2013-01-23T13:20:08Z
Comment #6 by github-bugzilla — 2013-01-23T17:19:07Z
Commits pushed to master at https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/77fbee1ef470d8916c1cc34fd0a91869f9292427 fix Issue 9369 - DDoc hardcodes '&' -> '&' in code https://github.com/D-Programming-Language/dmd/commit/9f780b01c551ff86b6cb9b9acd152dce158a7419 Merge pull request #1541 from WalterBright/fix9369again fix Issue 9369 - DDoc hardcodes '&' -> '&' in code
Comment #7 by andrei — 2013-01-23T22:15:41Z
Sorry, still no cigar. There are a few side effects of this change. * There are a lot more $(BR) introduced in the output. I think that's not bad actually, but it is a change in behavior. * The words "true", "false", and "null" now appear in DDOC_KEYWORD style everywhere. I had to define DDOC_KEYWORD=$0 to get rid of that. Let's say that's not bad either. * The main problem (and the reason I'm reopening this) is that now all code words that start with an underscore have it chopped off. For example $(D __FILE__) becomes _FILE__. I suppose that's because of the logic to avoid highlighting. That logic needs to somehow be removed in the general case. Everything else seems to work fine. Thanks!
Comment #8 by bugzilla — 2013-01-23T22:26:18Z
(In reply to comment #7) > There are a few side effects of this change. In ddoc files or d source code files?
Comment #9 by bugzilla — 2013-01-24T15:31:56Z
Comment #10 by github-bugzilla — 2013-01-24T16:02:38Z
Commits pushed to master at https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/c6e9191923faa52244feaf67772617f78ae07da0 fix Issue 9369 - DDoc hardcodes '&' -> '&' in code https://github.com/D-Programming-Language/dmd/commit/e7e0d1729994baee870d7b933292a8c22d8f3aa9 Merge pull request #1547 from WalterBright/b30 fix Issue 9369 - DDoc hardcodes '&' -> '&' in code