Bug 9611 – std.algorithm.nWayUnion(Tuple) too?

Status
ASSIGNED
Severity
enhancement
Priority
P4
Component
phobos
Product
D
Version
D2
Platform
All
OS
All
Creation time
2013-02-27T15:12:43Z
Last change time
2024-12-01T16:16:43Z
Assigned to
Andrei Alexandrescu
Creator
bearophile_hugs
Moved to GitHub: phobos#9957 →

Comments

Comment #0 by bearophile_hugs — 2013-02-27T15:12:43Z
In some cases I have had to merge ranges of different type. So maybe for such situations it's worth supporting nWayUnion of a Tuple of ranges: import std.algorithm: nWayUnion, map; import std.range: iota; import std.typecons: tuple; void main() { auto a = iota(10); auto b = [3, 6, 9]; auto c = iota(11).map!q{a * a}; auto r = nWayUnion(tuple(a, b, c)); } Note: in all such of my usage cases the number of the ranges was limited, 2 or 3. So when the input of nWayUnion is a tuple I think there is no need for nWayUnion to keep the ranges inside with a BinaryHeap. - - - - - - - - - - - - - - Current workaround, suggested by Ali Çehreli: import std.algorithm: nWayUnion, map; import std.range: iota, InputRange, inputRangeObject; void main() { InputRange!int a = inputRangeObject(iota(10)); InputRange!int b = inputRangeObject([3, 6, 9]); InputRange!int c = inputRangeObject(iota(11).map!q{a * a}); auto r = nWayUnion([a, b, c]); }
Comment #1 by zshazz — 2013-02-27T17:13:37Z
(In reply to comment #0) > Current workaround, suggested by Ali Çehreli: > > import std.algorithm: nWayUnion, map; > import std.range: iota, InputRange, inputRangeObject; > void main() { > InputRange!int a = inputRangeObject(iota(10)); > InputRange!int b = inputRangeObject([3, 6, 9]); > InputRange!int c = inputRangeObject(iota(11).map!q{a * a}); > auto r = nWayUnion([a, b, c]); > } A function that does the conversion to InputRange!E could easily be created and added to Phobos to handle this type of situation. Ranges such as nWayUnion could call this (currently poorly named) tupWrapper when isTuple!T returns true. --- import std.stdio, std.range, std.typecons, std.algorithm; void main() { auto tup = tuple(iota(5), repeat(1).take(3), [5,9,30]); foreach(e; tupWrapper(tup).nWayUnion()) writeln(e); } auto tupWrapper(Tup)(Tup tup) { alias E = ElementType!(Tup.Types[0]); InputRange!E[] arr; foreach(T; Tup.Types) static assert(is(ElementType!T == E)); foreach(ref e; tup) arr ~= inputRangeObject(e); return arr; } --- Currently, that solution isn't too robust. Ideally it would figure out the most powerful range type (either InputRange, ForwardRange, ..., RandomAccessRange) that all the types in the Tuple.Types support and it would return that.
Comment #2 by bearophile_hugs — 2013-02-27T17:24:55Z
(In reply to comment #1) > A function that does the conversion to InputRange!E could easily be created and > added to Phobos to handle this type of situation. I think InputRange and inputRangeObject are not needed to solve this. A "static foreach" on the Tuple fields (that contain ranges) looking for the smallest value seems enough to me.
Comment #3 by andrei — 2013-02-27T17:43:45Z
Yah, this should be added. Suffice to add a one-argument member function to SortedRange.
Comment #4 by robert.schadek — 2024-12-01T16:16:43Z
THIS ISSUE HAS BEEN MOVED TO GITHUB https://github.com/dlang/phobos/issues/9957 DO NOT COMMENT HERE ANYMORE, NOBODY WILL SEE IT, THIS ISSUE HAS BEEN MOVED TO GITHUB